lhames wrote:

> @lhames could you take a look, please?

Hi @dlav-sc. The `RuntimeDyld` changes look ok to me. We are hoping to switch 
LLDB to ORC / JITLink soon 
(https://discourse.llvm.org/t/rfc-removing-mcjit-and-runtimedyld/80464), but 
JITLink's RISCV support is pretty solid already -- I don't think we'll have any 
trouble moving over when we're ready.

If you want to test the RuntimeDyld changes you could add `llvm-rtdyld` tests 
(see `llvm/test/ExecutionEngine/RuntimeDyld`), but given that this is a 
stop-gap I'm ok with the changes going in as-is.

https://github.com/llvm/llvm-project/pull/99336
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to