jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land.
Looks fine. The only bad effect of making a CommandBaton, then going out of your way to put it in a plain old BatonSP before passing it to us rather than a CommandBatonSP is that the serialization code won't know it is a command baton, and won't serialize it. We use the llvm isa stuff in a bunch of places so if this becomes a problem it would be natural to fix it that way. https://reviews.llvm.org/D24495 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
