edmunoz added inline comments.
================
Comment at: tools/lldb-mi/MICmdArgValOptionLong.cpp:190
@@ -189,10 +189,3 @@
{
- CMIUtilString::VecString_t vecOptions;
- MIuint nOptionsPresent = 0;
- if ((m_eExpectingOptionType != eArgValType_StringQuoted) &&
(m_eExpectingOptionType != eArgValType_StringQuotedNumber) &&
- (m_eExpectingOptionType != eArgValType_StringQuotedNumberPath))
- nOptionsPresent = vrwTxt.GetArgsLeftToParse().Split(" ", vecOptions);
- else
- nOptionsPresent = vrwTxt.GetArgsLeftToParse().SplitConsiderQuotes(" ",
vecOptions);
- if (nOptionsPresent == 0)
+ if (vrwTxt.GetNumberArgsPresent() == 0)
return MIstatus::failure;
----------------
We could use the size of `vrwTxt.GetArgs()` to reduce the number of calls to
`CMIUtilString::SplitConsiderQuotes` in `CMICmdArgContext`.
I left it using the more expressive method name, but I'm open to changing it.
Repository:
rL LLVM
https://reviews.llvm.org/D24202
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
