clayborg requested changes to this revision.
This revision now requires changes to proceed.
================
Comment at: packages/Python/lldbsuite/test/lang/cpp/virtual/TestVirtual.py:64
@@ +63,3 @@
+ self.assertTrue(golden.IsValid(), "Encountered an error reading the
process's golden variable")
+ golden_str = str(golden)
+ self.assertTrue("c_as_C" in golden_str)
----------------
Are we relying on std::string data formatters working here? Seems like a
dangerous change as we would require any new ports of LLDB to have std::string
formatters working or this test will fail?
http://reviews.llvm.org/D20567
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
