labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

I agree with Todd that we should have a long option for this, as short ones 
tend to be cryptic. If we don't anticipate using this often (I don't), we could 
even drop the short option altogether, as it's only advantage is that it is 
shorter to type. I'll leave that up to you, no need to go through review second 
time.


================
Comment at: test/CMakeLists.txt:30
@@ -29,1 +29,3 @@
 
+set(LLDB_TEST_LOG_FORMAT
+    -S;nm
----------------
If you don't intend to use this functionality, I wouldn't be opposed to just 
hardcoding the default. Any advanced users needing to set this will probably 
invoke dotest directly. Doesn't really matter though...


http://reviews.llvm.org/D20306



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to