Note that while adding a "expr --allow-jit" flag to control this was great,
there already was an SBExpressionOptions option and the appropriate flags
available for this, so it was testable. I was just checking because there
really shouldn't be anything we can do from a command that we can't do from the
SB API's, but in this case the thing was already in the expression options.
We do prefer not to write tests with the command line when you can do it with
the Python API's. In our experience, command line tests have tended to be more
fragile. It's not necessary to change the test, there are plenty of other
command line tests lying around. Just for future reference...
Jim
> On May 9, 2016, at 1:01 PM, Sean Callanan via lldb-commits
> <lldb-commits@lists.llvm.org> wrote:
>
> spyffe accepted this revision.
> spyffe added a comment.
> This revision is now accepted and ready to land.
>
> This patch is fine. I especially appreciate the time you took making the
> IRInterpreter properly testable. I will use this myself.
>
>
> ================
> Comment at: source/Commands/CommandObjectExpression.cpp:67
> @@ -67,1 +66,3 @@
> + { LLDB_OPT_SET_1 | LLDB_OPT_SET_2, false, "top-level", 'p',
> OptionParser::eNoArgument , NULL, NULL, 0, eArgTypeNone,
> "Interpret the expression as top-level definitions rather than code to be
> immediately executed."},
> + { LLDB_OPT_SET_1 | LLDB_OPT_SET_2, false, "allow-jit", 'j',
> OptionParser::eRequiredArgument, nullptr, nullptr, 0, eArgTypeBoolean,
> "Controls whether the expression can fall back to being JITted if it's not
> supported by the interpreter (defaults to true)."}
> };
> ----------------
> This is a great feature which I will use in test cases.
>
> ================
> Comment at: source/Expression/IRInterpreter.cpp:1102
> @@ -1058,1 +1101,3 @@
> + }
> + break;
> case Instruction::GetElementPtr:
> ----------------
> Looks all right to me. Thank you!
>
>
> http://reviews.llvm.org/D19124
>
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
