labath accepted this revision. labath added a comment. In http://reviews.llvm.org/D15067#427848, @Eugene.Zelenko wrote:
> In http://reviews.llvm.org/D15067#427834, @krytarowski wrote: > > > In http://reviews.llvm.org/D15067#427814, @Eugene.Zelenko wrote: > > > > > I would like to see implemented my comment about LLVM_CONFIG and > > > find_program(). > > > > > > Could you first push this to clang? I don't want to drift from clang myself. > > > I'm not sure about Clang make files, but I built Clang with LLVM. LLDB is > more problematic, so I build it standalone with previously build Clang. This > why I'd like to specify path in CMake parameters, not relying in > find_program(). From cmake documentation on find program: This command is used to find a program. A cache entry named by <VAR> is created to store the result of this command. If the program is found the result is stored in the variable and the search will not be repeated unless the variable is cleared. So, I think the functionality you request is already baked into find_program and we should not duplicate it. I made a quick test and setting the variable via `-DLLVM_CONFIG` on the cmake command line does indeed prevent find-program from doing anything. (which is not surprising, as it is a fairly common use case for people to want to specify their own paths to things...) I think this is good to go know. I don't think we need to wait for @zturner, as his objections were about the regular expression thing, which has been removed now. Repository: rL LLVM http://reviews.llvm.org/D15067 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
