clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed.
I question if ArchSpec::GetClangTargetABI() belongs in ArchSpec. It is very clang specific. Should this just be a function in ClangExpressionParser? Like: static std::string ClangExpressionParser::GetTargetABI (const ArchSpec &arch); If no where else will require this target ABI, then this probably should not live in ArchSpec. Repository: rL LLVM http://reviews.llvm.org/D18638 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
