jingham added a subscriber: jingham.
jingham added a comment.

The source change looks fine, but Greg's the owner of this code so I'll let him 
say yes for sure.

But don't call the test case "ExpressionPath".  The expression parser is 
different from frame variable.  I understand that your intent was "the 
expression you feed to frame variable" but since we have an "expression" 
command, and the expressions you feed to it are different from those you feed 
to "frame variable" overloading the word is only going to cause confusion.


Repository:
  rL LLVM

http://reviews.llvm.org/D18005



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to