amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
Thanks for the fix.
Right now I'm trying to figure out why the test framework didn't detect the
crash and reported that all the tests passed.
================
Comment at: source/Expression/IRExecutionUnit.cpp:800
@@ -801,1 +799,3 @@
+ if (candidate_sc.symbol)
+ {
----------------
I'm OK with this, but I believe the LLDB style is to reverse the logic and use
an early-out (a `continue` in this case) rather than increasing the depth of
the rest of the code.
http://reviews.llvm.org/D17860
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
