zturner added a subscriber: zturner.
zturner requested changes to this revision.
zturner added a reviewer: zturner.
This revision now requires changes to proceed.
================
Comment at:
source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:206-210
@@ -199,1 +205,7 @@
+ if (target_machine == llvm::Triple::mips ||
+ target_machine == llvm::Triple::mipsel ||
+ target_machine == llvm::Triple::mips64 ||
+ target_machine == llvm::Triple::mips64el)
+ {
+ std::string cpu;
----------------
I don't like this big switch statement. This logic should be somewhere else,
for example on the `ArchSpec` class. And it should handle not just mips, but
everything.
Repository:
rL LLVM
http://reviews.llvm.org/D17022
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
