zturner added a comment.
In the future when you update the diff of a review, you need to base the diff
against the original code, not against your first diff. So the new diff should
be a superset of your old diff.
================
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1221-1234
@@ -1220,1 +1220,16 @@
+def skipUnlessMips(func):
+ """Decorate the item to skip tests that should be skipped only if not
building for any of the mips targets."""
+ if isinstance(func, type) and issubclass(func, unittest2.TestCase):
+ raise Exception("@skipIfNotMips can only be used to decorate a test
method")
+ @wraps(func)
+ def wrapper(*args, **kwargs):
+ from unittest2 import case
+ self = args[0]
+ arch = self.getArchitecture()
+ if not re.match('mips', arch):
+ self.skipTest("skipping because this is a mips specific test")
+ else:
+ func(*args, **kwargs)
+ return wrapper
+
----------------
You don't really need this, you can just use `@skipIf(archs=not_in(['mips']))`
Repository:
rL LLVM
http://reviews.llvm.org/D16049
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
