amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
I don't know enough about SWIG to give that a thorough review.
================
Comment at: source/Host/windows/ProcessLauncherWindows.cpp:38
@@ +37,3 @@
+ cur_entry += strlen(cur_entry) + sizeof(char);
+ }
+}
----------------
I would explicitly set
*cur_entry = '\0';
after the loop to make it clear that this is a null-terminated block of
null-terminated strings.
I get that buffer.resize(bytes) is going to zero out the bytes initially, _if_
it grows, so it's not technically necessary in the current use case. But if a
future caller calls it with a junk buffer that's already long enough (or
longer), then you could end up with a non-zero in that last byte.
http://reviews.llvm.org/D16128
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
