ldrumm requested a review of this revision. ldrumm added a comment. bump
================ Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:85-97 @@ -83,1 +84,15 @@ +namespace { + void debugStringVector(Log *log, const std::vector<std::string>& vec, const char *name) + { + if(!log) + return; + + log->Debug("Begin %s:", name); + for (const auto& s : vec) + log->Debug("%s", s.c_str()); + + log->Debug("End %s.", name); + } +} + ---------------- clayborg wrote: > We have an internal class named StringList that is a vector of strings. It > would be nice to use that class instead of a direct std::vector and place > this call inside the StringList class as a new method. Thanks for the suggestion. I've added that as a separate commit, as it touches an entirely different codepath: http://reviews.llvm.org/D15773 http://reviews.llvm.org/D15527 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits