LGTM.

I think we should submit this patch as tberghammer explained.

On 8 January 2016 at 19:24, Tamas Berghammer <tbergham...@google.com> wrote:
> tberghammer added a comment.
>
> @omjavaid: What is your opinion about submitting this patch in its current 
> form with knowing that setting watchpoints from a 64bit lldb-server into 
> 32bit inferior will fail?
>
> I think this patch is a step in the good direction to make a 64bit 
> lldb-server capable of debugging a 32bit inferior. Considering how few 
> arm/aarch64 (android) devices are supporting watchpoints I don't think we 
> should block on that issue.
>
>
> http://reviews.llvm.org/D15533
>
>
>
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to