amccarth marked 3 inline comments as done.
amccarth added a comment.
Thanks for the Linux check Pavel.
I'm running one last check and then I'll submit and keep an eye on the
buildbots for the rest of the day.
================
Comment at:
packages/Python/lldbsuite/test/functionalities/breakpoint/debugbreak/main.c:5
@@ +4,3 @@
+#else
+#define BREAKPOINT_INTRINSIC __asm__ __volatile__ ("int3");
+#endif
----------------
labath wrote:
> this will generate the wrong expansion (leaves `()` hanging). I recommend
> using the following:
> `#define BREAKPOINT_INTRINSIC() ...`
> to make sure the parens are consumed.
Whoops. Nice catch. Thanks.
http://reviews.llvm.org/D15834
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
