clayborg added a subscriber: clayborg.
clayborg added a comment.
I like the clang specific patch here better. Mainly because if you add a
function like this to TypeSystem.h:
virtual uint32_t
DeclContextCountDeclLevels (void *opaque_decl_ctx,
void *opaque_find_decl_ctx,
ConstString *find_name = nullptr,
CompilerType *find_type = nullptr) = 0;
It means that you will have a function in the CompilerDeclContext named
"CountDeclLevels(...)". The "DeclContext" prefix is the convention in
TypeSystem.h that says "I will add a corresponding function to
CompilerDeclContext that will call through to this function.
I still like the clang specific version better because I still think it doesn't
make a sensible API for CompilerDeclContext.
Greg
Repository:
rL LLVM
http://reviews.llvm.org/D15312
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
