abhishek.aggarwal added a comment.
Comments Inlined.
================
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:853-854
@@ +852,4 @@
+ {
+ if (log)
+ log->Printf("NativeRegisterContextLinux_x86_64::%s ptrace
APIs failed to read XSAVE/FXSAVE area", __FUNCTION__);
+ }
----------------
tberghammer wrote:
> Adding a log message is a good idea but please include the error message from
> ReadFPR in the log message. It will usually contain the error message
> returned by the ptrace call.
Error message from ReadFPR along with the error number (in case ptrace API
fails) are displayed during call of NativeProcessLinux::PtraceWrapper(). Hence,
to avoid multiplicity, I didn't include it here. The Log message I included is
an additional information regarding ptrace API failure.
http://reviews.llvm.org/D15042
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
