labath added a comment.

Seems legit, but @omjavaid can probably better verify the relationships among 
these registers. However, I would like to request some tests for this. AFAIK, 
we don't have a lot of (if any) arm-specific register tests. E.g. TestRegisters 
is skipped for non-x86 arches, so we could use this opportunity to add some 
arm-specific tests there.


================
Comment at: source/Plugins/Process/Utility/RegisterInfos_arm.h:41
@@ -40,3 +42,1 @@
-#ifndef DBG_OFFSET
-#error DBG_OFFSET_NAME must be defined before including this header file
 #endif
----------------
Was removing DBG_OFFSET intentional?


http://reviews.llvm.org/D14985



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to