tberghammer requested changes to this revision.
tberghammer added a comment.
This revision now requires changes to proceed.

You are created a new ReadRegisterUnsigned method in the derived class what 
will hide a method from the base class with the same name but with different 
return type. I think from code health perspective it is a very bad idea and 
will lead to surprising differences between calling ReadRegisterUnsigned on an 
EmulateInstruction* or on an EmulateInstructionMIPS* with the same underlying 
object.

The route cause of your problem is that ReadRegisterUnsigned returns a value 
where the 32 MSB is garbage while the expected behavior is to zero out those 
bits (it works on i386 and arm AFAIK). You should find out why that is 
happening and fix the root cause of it what will fix your single stepping issue 
as well.


Repository:
  rL LLVM

http://reviews.llvm.org/D14633



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to