labath added a subscriber: labath. ================ Comment at: test/make/Makefile.rules:304 @@ -303,3 +303,3 @@ else - CXXFLAGS += -stdlib=libc++ + CXXFLAGS += -stdlib=libc++ -DLLDB_USING_LIBCPP LDFLAGS += -stdlib=libc++ ---------------- Thanks for fixing the build.
When I get libc++ detection and skipping logic centralized, I'd like to remove this magic and make self.build() fail with a hard error in the case when the Makefile requests libc++ use, but the library is not present. The skipping logic should fire before self.build(), but it we still end up attempting to build, then that's something we should know about. How does that sound? http://reviews.llvm.org/D13964 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits