zturner added a comment.

I thought about this some more and I'm fine with going with a single 
implementation and not using std async.  It would be nice to take advantage of 
any deep optimizations std::async provides over a hand-rolled solution, but at 
the same time there's a cost to adding complexity and asymmetric 
implementations, even if the asymmetry is hidden behind this interface.  And 
the gain we get from goign single threaded -> this implementation is much 
greater than we would theoretically get from going from this implementation -> 
std async.

I'll look more closely at the implementation and see if I have other comments, 
but the general idea is fine.


http://reviews.llvm.org/D13727



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to