enlight added inline comments.

================
Comment at: cmake/modules/LLDBConfig.cmake:113
@@ +112,3 @@
+  set (PYTHON_LIBRARY ${PYTHON_LIBRARY} PARENT_SCOPE)
+  set (PYTHON_DLL ${PYTHON_LIBRARY} PYTHON_DLL PARENT_SCOPE)
+  set (PYTHON_INCLUDE_DIRS ${PYTHON_INCLUDE_DIRS} PARENT_SCOPE)
----------------
You missed :P

================
Comment at: cmake/modules/LLDBConfig.cmake:140
@@ -106,1 +139,3 @@
+  
+  if (PYTHON_LIBRARY)
     include_directories(${PYTHON_INCLUDE_DIRS})
----------------
Can we make this `if (PYTHON_INCLUDE_DIRS)` instead?


http://reviews.llvm.org/D13404



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to