dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
This commit caused a regression when evaluating globals inside a namespace.
See comments in the following narrowed test case. Can you have a look please?
(Note: test case was tested with clang based on svn 3.4, 3.6 and trunk on OSX).
Thanks!
#include <stdio.h>
int make_used;
static int ScNSpacGl = 2100;
namespace NS2 {
static int ScNSpacGl = 2111;
static void NS2Func(void) {
// BP2, eval ::ScNSpacGl, Exp: 2100 Act: 2111, caused by commit
28746fe (svn.247746)
printf("eval @BP2 line=%d: ::ScNSpacGl = %d\n", __LINE__,
::ScNSpacGl);
make_used += ScNSpacGl;
}
}
int main(int argc, char **argv) {
NS2::NS2Func();
return make_used == 0;
}
Users:
paulherman (Author)
dawn (Auditor)
http://reviews.llvm.org/rL247746
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
