labath added a subscriber: labath.
labath added a comment.
I don't know much about the arm unwind info, but I have some style comments
from a casual read-through.
================
Comment at: include/lldb/Symbol/UnwindTable.h:71
@@ -67,4 +70,3 @@
- DWARFCallFrameInfo* m_eh_frame;
- CompactUnwindInfo *m_compact_unwind;
-
+ std::unique_ptr<DWARFCallFrameInfo> m_eh_frame;
+ std::unique_ptr<CompactUnwindInfo> m_compact_unwind;
----------------
unique pointers should have names ending in _up
================
Comment at: source/Symbol/ArmUnwindInfo.cpp:62
@@ +61,3 @@
+static uint64_t
+GetULEB128(const uint32_t* data, uint16_t& offset, uint16_t max_offset)
+{
----------------
Is there a reason DataExtractor::GetULEB128 could not be reused?
http://reviews.llvm.org/D13245
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
