On Mon, Feb 15, 2016 at 02:25:53PM +1100, Andrew Donnellan wrote: >On 15/02/16 10:52, Gavin Shan wrote: >>When eeh_dump_pe_log() is called in eeh_slot_error_detail(), we >>already have the check that the PE isn't in PCI config blocked >>state. So we needn't the duplicated check in eeh_dump_pe_log(). >> >>This removes the duplicated check in eeh_dump_pe_log(). >> >>Signed-off-by: Gavin Shan <gws...@linux.vnet.ibm.com> > >eeh_dump_pe_log() isn't called anywhere outside of eeh_slot_error_detail(), >so this should have no functional change. > >Reviewed-by: Andrew Donnellan <andrew.donnel...@au1.ibm.com> >
Thanks for review. Do you want to see revised patch to include your comments? Thanks, Gavin >-- >Andrew Donnellan Software Engineer, OzLabs >andrew.donnel...@au1.ibm.com Australia Development Lab, Canberra >+61 2 6201 8874 (work) IBM Australia Limited _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev