On Mon, 2016-18-01 at 00:44:27 UTC, Michael Ellerman wrote: > From: Alan Modra <amo...@gmail.com> > > PowerPC64 uses the symbol .TOC. much as other targets use > _GLOBAL_OFFSET_TABLE_. It identifies the value of the GOT pointer (or in > powerpc parlance, the TOC pointer). Global offset tables are generally > local to an executable or shared library, or in the kernel, module. Thus > it does not make sense for a module to resolve a relocation against > .TOC. to the kernel's .TOC. value. A module has its own .TOC., and > indeed the powerpc64 module relocation processing ignores the kernel > value of .TOC. and instead calculates a module-local value. > > This patch removes code involved in exporting the kernel .TOC., tweaks > modpost to ignore an undefined .TOC., and the module loader to twiddle > the section symbol so that .TOC. isn't seen as undefined. > > Note that if the kernel was compiled with -msingle-pic-base then ELFv2 > would not have function global entry code setting up r2. In that case > the module call stubs would need to be modified to set up r2 using the > kernel .TOC. value, requiring some of this code to be reinstated. > > mpe: Furthermore a change in binutils master (not yet released) causes > the current way we handle the TOC to no longer work when building with > MODVERSIONS=y and RELOCATABLE=n. The symptom is that modules can not be > loaded due to there being no version found for TOC. > > Cc: sta...@vger.kernel.org # 3.16+ > Signed-off-by: Alan Modra <amo...@gmail.com> > Signed-off-by: Michael Ellerman <m...@ellerman.id.au>
Applied to powerpc fixes. https://git.kernel.org/powerpc/c/c153693d7eb9eeb28478aa2dea cheers _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
