On Tue, 2015-27-10 at 15:46:47 UTC, Nathan Fontenot wrote: > Commit a030e1e4bbd085bbcfd0a23f8d355fcd41f39bed make a change to use > kstrndup() instead of kmalloc() + strlcpy() in the pseries_of_derive_parent() > routine that introduces a subtle change in the parent path name generated. > The kstrndup() routine will copy n characters followed by a terminating null, > whereas strlcpy() will copy n-1 characters and add a terminating null. > > This slight difference results in having a parent path that includes the > tailing '/' character, "/cpus/" vs. "/cpus". This then causes the subsequent > call to of_find_node_by_path() to fail, and in the case of DLPAR add > operations the DLPAR request fails. > > This patch decrements the pointer returned from kbasename() to point to the > '/' character before the base name instead of the base name. This then > adjusts the string length calculations to not include the trailing '/' > in the parent path name. > > Signed-off-by: Nathan Fontenot <nf...@linux.vnet.ibm.com> > Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/f755ecfb8cec7b19dff84295 cheers _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
