On 21.10.2015 22:14, Matthew R. Ochs wrote: > The AFU version is stored as a non-terminated string of bytes within > a 64-bit little-endian register. Presently the value is read directly > (no MMIO accessor) and is stored in a buffer that is not big enough > to contain a NULL terminator. Additionally the version obtained is not > evaluated against a known value to prevent usage with unsupported AFUs. > All of these deficiencies can lead to a variety of problems. > > To remedy, use the correct MMIO accessor to read the version value into > a null-terminated buffer and add a check to prevent an incompatible AFU > from being used with this driver. > > Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > Signed-off-by: Manoj N. Kumar <ma...@linux.vnet.ibm.com> > Reviewed-by: Brian King <brk...@linux.vnet.ibm.com> > Reviewed-by: Daniel Axtens <d...@axtens.net>
Reviewed-by: Tomas Henzl <the...@redhat.com> Tomas _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
