On Tue, 2015-10-06 at 16:35 +0200, Christophe Leroy wrote: > Le 29/09/2015 02:03, Scott Wood a écrit : > > On Tue, Sep 22, 2015 at 06:50:58PM +0200, Christophe Leroy wrote: > > > Move 8xx SPRN defines into reg_8xx.h and add some missing ones > > > > > > Signed-off-by: Christophe Leroy <christophe.le...@c-s.fr> > > > --- > > > No change in v2 > > Why are they being moved? Why are they being separated from the bit > > definitions? > > > > > It was to keep asm/reg_8xx.h self sufficient for the following patch.
Again, it would have been nice if this were in the commit message. > Also because including asm/mmu-8xx.h creates circular inclusion issue > (mmu-8xx.h needs page.h which includes page-32.h, page-32.h includes > cache.h, cache.h include reg.h which includes reg_8xx). The circle > starts with an inclusion of asm/cache.h by linux/cache.h, himself > included by linux/printk.h, and I end up with 'implicit declaration' issues. > > How can I fix that ? mmu-8xx.h should have been including page.h instead of assuming the caller h as done so... but another option is to do what mmu-book3e.h does, and use the kconfig symbols instead of PAGE_SHIFT. -Scott _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
