>>> Following an adapter reset, the AFU RRQ that resides in host memory >>> holds stale data. This can lead to a condition where the RRQ interrupt >>> handler tries to process stale entries and/or endlessly loops due to an >>> out of sync generation bit. >>> >>> To fix, the AFU RRQ in host memory needs to be cleared after each reset. >> >> This looks good. Do you need anything to bail out of cxlflash_rrq_irq if >> the data goes stale or to all Fs while that function is running? > > We're not performing an MMIO here, so I'm not sure how the all Fs check > would apply. We're also protected fairly well by the generation bit. I suppose > we could look at adding some type of 'max iterations' count to protect against > a runaway handler but that would be in a future patch.
Ah, right you are. I had confused all Fs with UEs. Reviewed-by: Daniel Axtens <d...@axtens.net> Regards, Daniel _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
