On Thu, Sep 17, 2015 at 11:47 AM, Michael Ellerman <m...@ellerman.id.au> wrote: > On Thu, 2015-09-17 at 11:18 +0200, Peter Senna Tschudin wrote: >> Returning a negative value for a boolean function seem to have the >> undesired effect of returning true. Replace -EINVAL by false in a >> bool-returning function. >> >> The diff of the .s file before and after the change (using cross >> compilation) starts with: >> >> 440,441c440,441 >> < .L43: >> < li 3,1 # D.25775, >> --- >> > .L42: >> > li 3,0 # D.25775, >> ... >> >> while if -EFAULT is replaced by true, the diff is empty. > > Ah, that's rather unfortunate. > > Can you post the full asm listing, for all three cases? Sure, but it would be 3 files of 70kb each. You can download them form:
http://petersenna.com/files/module_64.s.tar.xz Let me know if this download method doesn't work for you. module_64.s: Original file. module_64-patched.s: With my patch module_64-true.s: Changing -EFAULT by true files were made with: $ make arch/powerpc/kernel/module_64.s using: gcc-powerpc64-linux-gnu-4.9.2-5.fc21.x86_64 > > cheers > > -- Peter _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
