On 03.09.2015 [19:58:53 +1000], Michael Ellerman wrote:
> On Wed, 2015-09-02 at 08:39 -0700, Nishanth Aravamudan wrote:
> > On 02.09.2015 [19:00:31 +1000], Alexey Kardashevskiy wrote:
> > > On 09/02/2015 11:11 AM, Nishanth Aravamudan wrote:
> > > >diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c
> > > >b/arch/powerpc/platforms/powernv/pci-ioda.c
> > > >index 85cbc96eff6c..0d7967e31169 100644
> > > >--- a/arch/powerpc/platforms/powernv/pci-ioda.c
> > > >+++ b/arch/powerpc/platforms/powernv/pci-ioda.c
> > > >@@ -2077,10 +2077,17 @@ static long
> > > >pnv_pci_ioda2_setup_default_config(struct pnv_ioda_pe *pe)
> > > > {
> > > > struct iommu_table *tbl = NULL;
> > > > long rc;
> > > >+ /*
> > > >+ * In memory constrained environments, e.g. kdump kernel, the
> > > >+ * DMA window can be larger than available memory, which will
> > > >+ * cause errors later.
> > > >+ */
> > > >+ __u64 window_size =
> > >
> > > I asked for "const __u64" ;)
> >
> > I knew I'd forget something!
>
> Nish! In future please send a reply with the above comment, and then
> the v2 as a separate mail, otherwise I have to manually edit out your
> comment when applying.
Sorry! Will amend my practices in the future.
<snip>
> > Fixes: aca6913f5551 ("powerpc/powernv/ioda2: Introduce helpers to allocate
> > TCE pages")
>
> That went into 4.2, so should this have a:
>
> Cc: [email protected] # 4.2
Grr, another mess-up, you're right, it should. Can you amend on your
end? Sorry, I was in too much of a hurry to get the fixlet out.
-Nish
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev
