On Wed, 2015-08-19 at 15:12 +1000, Ian Munsie wrote: > Excerpts from Michael Ellerman's message of 2015-08-19 14:49:30 +1000: > > Do we really need the accessors? They don't buy anything I can see over just > > using ctx->priv directly. > > The reasoning there is because we don't currently expose the contents of > stuct cxl_context to afu drivers, rather they just treat it as an opaque > type. > > We could potentially change this to expose the details, but there's a > lot of junk in there that's just internal details of the cxl driver that > isn't of interest to an afu driver that I'd rather not expose. > > We also already have another accessor function (cxl_process_element) in > the api, so it's not out of place. > > FWIW I'm not opposed to changing how this api works if it ultimately > makes things better, but I want to wait until the cxlflash superpipe > support is merged so any patches that change the api can change it at > the same time.
OK. I saw struct cxl_context in cxl.h and figured it was public, but it's in drivers/misc/cxl/cxl.h, so yes other drivers have no business poking in there, even though they *could*. So that's fine. cheers _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
