On Wed, 2015-07-15 at 21:37 -0500, Lu Yangbo-B47093 wrote:
> Any comments?
> Thanks.
Sorry, I must have missed this on my last time through the patch queue. I
see you've decimalized the fiper and max-adj properties, which is good... but
does it really make sense for tmr-add? I'm not familiar with what this value
represents, but the numbers look more natural as hex (e.g. 0xaaaaaaab versus
2863311531).
> > diff --git a/arch/powerpc/boot/dts/p2020rdb-pc.dtsi
> > b/arch/powerpc/boot/dts/p2020rdb-pc.dtsi
> > index c21d1c7..363172d 100644
> > --- a/arch/powerpc/boot/dts/p2020rdb-pc.dtsi
> > +++ b/arch/powerpc/boot/dts/p2020rdb-pc.dtsi
> > @@ -215,12 +215,12 @@
> > };
> >
> > ptp_clock@24e00{
> > - fsl,tclk-period = <5>;
> > - fsl,tmr-prsc = <200>;
> > - fsl,tmr-add = <0xCCCCCCCD>;
> > - fsl,tmr-fiper1 = <0x3B9AC9FB>;
> > - fsl,tmr-fiper2 = <0x0001869B>;
> > - fsl,max-adj = <249999999>;
> > + fsl,tclk-period = <5>;
> > + fsl,tmr-prsc = <2>;
> > + fsl,tmr-add = <2863311531>;
> > + fsl,tmr-fiper1 = <999999995>;
> > + fsl,tmr-fiper2 = <99990>;
> > + fsl,max-adj = <299999999>;
> > };
And here, you're changing the value of fsl,tmr-add and fsl,max-adj. Why?
-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
