On 2015/03/13 08:20PM, Masami Hiramatsu wrote: > (2015/03/13 5:24), Arnaldo Carvalho de Melo wrote: > > Em Mon, Dec 15, 2014 at 08:20:32PM +0530, Naveen N. Rao escreveu: > >> Currently, perf probe considers patterns including a '.' to be a file. > >> However, this causes problems on powerpc ABIv1 where all functions have > >> a leading '.': > >> > >> $ perf probe -F | grep schedule_timeout_interruptible > >> .schedule_timeout_interruptible > >> $ perf probe .schedule_timeout_interruptible > >> Semantic error :File always requires line number or lazy pattern. > >> Error: Command Parse Error. > >> > >> Fix this by checking the probe pattern in more detail. > > > > Masami, can I have your Acked-by or Reviewed-by? > > As far as I can see, this is not enough for fixing that issue. > Could you fold the first half of [4/8] to this patch? > I also have some comments on it. See below.
Masami, Arnaldo, Thanks for the review. v3 patches forthcoming... - Naveen _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
