Hi Laurentiu, Thanks for your comments. Reply inline.
Regards Sandeep > -----Original Message----- > From: Linuxppc-dev [mailto:linuxppc-dev- > bounces+sandeep=freescale....@lists.ozlabs.org] On Behalf Of Laurentiu Tudor > Sent: Thursday, April 02, 2015 5:26 PM > To: linuxppc-dev@lists.ozlabs.org > Subject: Re: [1/3][PATCH][v2] Device Tree bindings for Freescale TDM > controller > > Hi Sandeep, > > Small nit inside. > > On 04/02/2015 01:47 PM, sand...@freescale.com wrote: > > From: Sandeep Singh <sand...@freescale.com> > > > > This controller is available on many Freescale SOCs like MPC8315, > > P1020, P1010, > > P1022 and P1024 > > > > Signed-off-by: Sandeep Singh <sand...@freescale.com> > > Signed-off-by: Poonam Aggrwal <poonam.aggr...@freescale.com> > > --- > > Documentation/devicetree/bindings/tdm/fsl-tdm.txt | 65 > +++++++++++++++++++++ > > 1 files changed, 65 insertions(+), 0 deletions(-) create mode 100644 > > Documentation/devicetree/bindings/tdm/fsl-tdm.txt > > > > diff --git a/Documentation/devicetree/bindings/tdm/fsl-tdm.txt > > b/Documentation/devicetree/bindings/tdm/fsl-tdm.txt > > new file mode 100644 > > index 0000000..1258b89 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/tdm/fsl-tdm.txt > > @@ -0,0 +1,65 @@ > > > +================================================================= > ==== > > +TDM Device Tree Binding > > +Copyright (C) 2012 Freescale Semiconductor Inc. > > + > > +NOTE: The bindings described in this document are preliminary and > > +subject to change. > > + > > > +================================================================= > ==== > > +TDM (Time Division Multiplexing) > > + > > +DESCRIPTION > > + > > +The TDM is full duplex serial port designed to allow various devices > > +including digital signal processors (DSPs) to communicate with a > > +variety of serial devices including industry standard framers, codecs, > > other > DSPs and microprocessors. > > + > > +The below properties describe the device tree bindings for Freescale > > +TDM controller. > > +This TDM controller is available on various Freescale Processors like > > +MPC8313, P1020, P1022 and P1010. > > + > > +PROPERTIES > > + > > + - compatible > > + Usage: required > > + Value type: <string> > > + Definition: Should contain "fsl,tdm1.0". > > + > > + - reg > > + Usage: required > > + Definition: A standard property. The first reg specifier describes > > the > > + TDM registers, and the second describes the TDM DMAC registers. > > + > > + - clock-frequency > > + Usage: optional > > + Value type: <u32 or u64> > > + Definition: The frequency at which the TDM block is operating. > > + > > + - interrupts > > + Usage: required > > + Definition: Definition: Two interrupt specifiers. The first is > > + TDM > > Extra "Definition:" here. [Sandeep] Yes, will remove it. > > --- > Best Regards, Laurentiu > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev