On Wed, 2015-04-01 at 19:19 +0300, Madalin Bucur wrote:
> Add trace points on the hot processing path.
more trivia:
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth_trace.h
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth_trace.h
[]
> +#define fd_format_name(format) { qm_fd_##format, #format }
> +#define fd_format_list \
> + fd_format_name(contig), \
> + fd_format_name(sg)
Are these used anywhere?
> +#define TR_FMT "[%s] fqid=%d, fd: addr=0x%llx, format=%s, off=%u, len=%u," \
> + " status=0x%08x"
It's nicer to coalesce string fragments.
Unless this is intended to be used more than once,
perhaps it's better to remove it and use the string
directly instead.
> + /* This is what gets printed when the trace event is triggered */
> + TP_printk(TR_FMT,
> + __get_str(name), __entry->fqid, __entry->fd_addr,
> + __print_symbolic(__entry->fd_format, fd_format_list),
> + __entry->fd_offset, __entry->fd_length, __entry->fd_status)
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
