On Tue, 2015-03-31 at 08:46 +1100, Benjamin Herrenschmidt wrote: > On Mon, 2015-03-30 at 23:32 +1100, Michael Ellerman wrote: > > On Wed, 2015-25-03 at 05:35:36 UTC, Daniel Axtens wrote: > > > > Why did we move it? Just for cleanliness? > > > > > diff --git a/arch/powerpc/platforms/powermac/pmac.h > > > b/arch/powerpc/platforms/powermac/pmac.h > > > index 8327cce..46d2193 100644 > > > --- a/arch/powerpc/platforms/powermac/pmac.h > > > +++ b/arch/powerpc/platforms/powermac/pmac.h > > > @@ -39,4 +39,8 @@ extern void low_cpu_die(void) __attribute__((noreturn)); > > > extern int pmac_nvram_init(void); > > > extern void pmac_pic_init(void); > > > > > > +#ifdef CONFIG_PPC64 > > > +extern int pmac_pci_probe_mode(struct pci_bus *bus); > > > +#endif > > > > You don't need to ifdef declarations, and you don't need extern. > > I like extern :-) If the rest of the file use it, I prefer if he > continues doing so.
I like Ponies. It's fashionable to not use it, and I expect we'll start seeing treewide extern-removal series soon enough, but whatever. cheers _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
