On Tue, 2015-01-20 at 04:09 -0600, Emil Medve wrote: > Where the memset() is not necessary > > Signed-off-by: Emil Medve <emilian.me...@freescale.com> > --- > drivers/clk/clk-ppc-corenet.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/clk-ppc-corenet.c b/drivers/clk/clk-ppc-corenet.c > index d84a7f0..91816b1 100644 > --- a/drivers/clk/clk-ppc-corenet.c > +++ b/drivers/clk/clk-ppc-corenet.c > @@ -185,7 +185,7 @@ static void __init core_pll_init(struct device_node *np) > if (!subclks) > goto err_map; > > - onecell_data = kzalloc(sizeof(*onecell_data), GFP_KERNEL); > + onecell_data = kmalloc(sizeof(*onecell_data), GFP_KERNEL); > if (!onecell_data) > goto err_clks; >
I think it's better to use kzalloc always, outside of performance-sensitive allocations. E.g. what if a new field is added to the struct later? -Scott _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
