> > @@ -806,8 +837,8 @@ static int cxl_read_vsec(struct cxl *adapter, struct > > pci_dev *dev) > > CXL_READ_VSEC_BASE_IMAGE(dev, vsec, &adapter->base_image); > > CXL_READ_VSEC_IMAGE_STATE(dev, vsec, &image_state); > > adapter->user_image_loaded = !!(image_state & > > CXL_VSEC_USER_IMAGE_LOADED); > > - adapter->perst_loads_image = !!(image_state & > > CXL_VSEC_PERST_LOADS_IMAGE); > > - adapter->perst_select_user = !!(image_state & > > CXL_VSEC_PERST_SELECT_USER); > > + adapter->perst_loads_image = true; > > + adapter->perst_select_user = !!(image_state & > > CXL_VSEC_USER_IMAGE_LOADED); > ... > > + if ((rc = cxl_update_image_control(adapter))) > > + goto err2; > > Thanks - that seems like a better default than what we had before, > should make things more stable :)
In fact, would you mind pulling this part out into a separate patch? It seems like a serious contender to go to stable as it might help with cards that get into a funny state and don't come back up properly after a reboot (symptoms are that the adapter wide tlbia / slbia times out and the driver aborts initialisation). Cheers, -Ian _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
