On Wed, 2014-11-26 at 15:56 +0530, Mahesh Jagannath Salgaonkar wrote:
> On 11/26/2014 09:14 AM, Michael Ellerman wrote:
> > On Thu, 2014-20-11 at 04:14:36 UTC, Mahesh Salgaonkar wrote:
> >> From: Mahesh Salgaonkar <mah...@linux.vnet.ibm.com>
> >>
> >> The current HMI event structure is an ABI and carries a version field to
> >> accommodate future changes without affecting/rearranging current structure
> >> members that are valid for previous versions. The current version check
> >> "if (hmi_evt->version != OpalHMIEvt_V1)" seems to consider that version
> >> will always be V1 which may not be true in future. If we start supporting
> >> HMI event > V1, this check would fail without printing anything on older
> >> kernels. This patch fixes this issue.
> >
> > It's not clear what you mean when you say "this check would fail without
> > printing anything". The check will fail, and it will print something, ie.
> > the
> > error message.
> >
> > What you mean is "the check will fail, and the HMI info will not be
> > printed".
>
> My Bad, Yes. I meant 'HMI info will not be printed'. Do you want me to
> re spin the patch with correction.
No that's fine, I've fixed it up to be:
The current HMI event structure is an ABI and carries a version field to
accommodate future changes without affecting/rearranging current structure
members that are valid for previous versions.
The current version check "if (hmi_evt->version != OpalHMIEvt_V1)"
doesn't accomodate the fact that the version number may change in
future.
If firmware starts returning an HMI event with version > 1, this check
will fail and no HMI information will be printed on older kernels.
This patch fixes this issue.
> > I'll CC this to stable unless you disagree.
>
> Yes. This patch needs to go to stable.
Yep I've added Cc stable to the patch.
cheers
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
