Hello Viresh,
When I use -C -M options, checkpatch reports error:
[tangyt@titan linux-pm]$ ./scripts/checkpatch.pl
0002-cpufreq-qoriq-rename-the-driver.patch
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15:
drivers/cpufreq/{ppc-corenet-cpufreq.c => qoriq-cpufreq.c} | 0
ERROR: Does not appear to be a unified-diff format patch
total: 1 errors, 1 warnings, 0 lines checked
0002-cpufreq-qoriq-rename-the-driver.patch has style problems, please review.
I just rename it and do not change anyting. Isn't that allowed?
Thanks,
Yuantian
> -----Original Message-----
> From: Viresh Kumar [mailto:viresh.ku...@linaro.org]
> Sent: Friday, November 21, 2014 3:56 PM
> To: Tang Yuantian-B29983
> Cc: Rafael J. Wysocki; Linux Kernel Mailing List; linux...@vger.kernel.org;
> linuxppc-...@ozlabs.org; Jin Zhengxiong-R64188
> Subject: Re: [PATCH 2/2] cpufreq: qoriq: rename the driver
>
> On 21 November 2014 12:58, Tang Yuantian <yuantian.t...@freescale.com>
> wrote:
> > This driver works on all QorIQ platforms which include ARM-based cores
> > and PPC-based cores.
> > Rename it in order to represent better.
> >
> > Signed-off-by: Tang Yuantian <yuantian.t...@freescale.com>
> > ---
> > drivers/cpufreq/ppc-corenet-cpufreq.c | 371
> > ----------------------------------
> > drivers/cpufreq/qoriq-cpufreq.c | 371
> ++++++++++++++++++++++++++++++++++
> > 2 files changed, 371 insertions(+), 371 deletions(-) delete mode
> > 100644 drivers/cpufreq/ppc-corenet-cpufreq.c
> > create mode 100644 drivers/cpufreq/qoriq-cpufreq.c
>
> This is not reviewable at all.. How do I verify that you haven't changed
> something
> in the files as well ?
>
> To make life easy always create patches with:
>
> git format-patch -C -M
>
> Above options handle renames pretty well.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
