On 11/3/14, Philippe Bergheaud <fe...@linux.vnet.ibm.com> wrote: > Denis Kirjanov wrote: >> Any feedback from PPC folks? > > I have reviewed the patch and it looks fine to me. > I have tested successfuly on ppc64le. > I could not test it on ppc64.
Nice, I've tested it on PPC64be > > Philippe > >> On 10/26/14, Denis Kirjanov <k...@linux-powerpc.org> wrote: >> >>>Cc: Matt Evans <m...@ozlabs.org> >>>Signed-off-by: Denis Kirjanov <k...@linux-powerpc.org> >>>--- >>> arch/powerpc/include/asm/ppc-opcode.h | 1 + >>> arch/powerpc/net/bpf_jit.h | 7 +++++++ >>> arch/powerpc/net/bpf_jit_comp.c | 5 +++++ >>> 3 files changed, 13 insertions(+) >>> >>>diff --git a/arch/powerpc/include/asm/ppc-opcode.h >>>b/arch/powerpc/include/asm/ppc-opcode.h >>>index 6f85362..1a52877 100644 >>>--- a/arch/powerpc/include/asm/ppc-opcode.h >>>+++ b/arch/powerpc/include/asm/ppc-opcode.h >>>@@ -204,6 +204,7 @@ >>> #define PPC_INST_ERATSX_DOT 0x7c000127 >>> >>> /* Misc instructions for BPF compiler */ >>>+#define PPC_INST_LBZ 0x88000000 >>> #define PPC_INST_LD 0xe8000000 >>> #define PPC_INST_LHZ 0xa0000000 >>> #define PPC_INST_LHBRX 0x7c00062c >>>diff --git a/arch/powerpc/net/bpf_jit.h b/arch/powerpc/net/bpf_jit.h >>>index 9aee27c..c406aa9 100644 >>>--- a/arch/powerpc/net/bpf_jit.h >>>+++ b/arch/powerpc/net/bpf_jit.h >>>@@ -87,6 +87,9 @@ DECLARE_LOAD_FUNC(sk_load_byte_msh); >>> #define PPC_STD(r, base, i) EMIT(PPC_INST_STD | ___PPC_RS(r) | \ >>> ___PPC_RA(base) | ((i) & 0xfffc)) >>> >>>+ >>>+#define PPC_LBZ(r, base, i) EMIT(PPC_INST_LBZ | ___PPC_RT(r) | \ >>>+ ___PPC_RA(base) | IMM_L(i)) >>> #define PPC_LD(r, base, i) EMIT(PPC_INST_LD | ___PPC_RT(r) | \ >>> ___PPC_RA(base) | IMM_L(i)) >>> #define PPC_LWZ(r, base, i) EMIT(PPC_INST_LWZ | ___PPC_RT(r) | \ >>>@@ -96,6 +99,10 @@ DECLARE_LOAD_FUNC(sk_load_byte_msh); >>> #define PPC_LHBRX(r, base, b) EMIT(PPC_INST_LHBRX | ___PPC_RT(r) | >>> \ >>> ___PPC_RA(base) | ___PPC_RB(b)) >>> /* Convenience helpers for the above with 'far' offsets: */ >>>+#define PPC_LBZ_OFFS(r, base, i) do { if ((i) < 32768) PPC_LBZ(r, base, >>> i); >>> \ >>>+ else { PPC_ADDIS(r, base, IMM_HA(i)); \ >>>+ PPC_LBZ(r, r, IMM_L(i)); } } while(0) >>>+ >>> #define PPC_LD_OFFS(r, base, i) do { if ((i) < 32768) PPC_LD(r, base, >>> i); >>> \ >>> else { PPC_ADDIS(r, base, IMM_HA(i)); \ >>> PPC_LD(r, r, IMM_L(i)); } } while(0) >>>diff --git a/arch/powerpc/net/bpf_jit_comp.c >>>b/arch/powerpc/net/bpf_jit_comp.c >>>index cbae2df..d110e28 100644 >>>--- a/arch/powerpc/net/bpf_jit_comp.c >>>+++ b/arch/powerpc/net/bpf_jit_comp.c >>>@@ -407,6 +407,11 @@ static int bpf_jit_build_body(struct bpf_prog *fp, >>> u32 >>>*image, >>> PPC_LHZ_OFFS(r_A, r_skb, offsetof(struct sk_buff, >>> queue_mapping)); >>> break; >>>+ case BPF_ANC | SKF_AD_PKTTYPE: >>>+ PPC_LBZ_OFFS(r_A, r_skb, PKT_TYPE_OFFSET()); >>>+ PPC_ANDI(r_A, r_A, PKT_TYPE_MAX); >>>+ PPC_SRWI(r_A, r_A, 5); >>>+ break; >>> case BPF_ANC | SKF_AD_CPU: >>> #ifdef CONFIG_SMP >>> /* >>>-- >>>2.1.0 >>> >>> >> >> _______________________________________________ >> Linuxppc-dev mailing list >> Linuxppc-dev@lists.ozlabs.org >> https://lists.ozlabs.org/listinfo/linuxppc-dev > > _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev