On Wed, 2014-10-08 at 09:59 +1100, Michael Ellerman wrote: > On Tue, 2014-07-10 at 10:48:14 UTC, Michael Neuling wrote: > > From: Ian Munsie <imun...@au1.ibm.com> > > > > This adds a number of functions for allocating IRQs under powernv PCIe for > > cxl. > > > > diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c > > b/arch/powerpc/platforms/powernv/pci-ioda.c > > index baf3de6..3b67010b 100644 > > --- a/arch/powerpc/platforms/powernv/pci-ioda.c > > +++ b/arch/powerpc/platforms/powernv/pci-ioda.c > > @@ -38,6 +38,8 @@ > > #include <asm/debug.h> > > #include <asm/firmware.h> > > > > +#include <misc/cxl.h> > > You should be including pnv-pci.h here. > > Otherwise the header and the implementation could get out of sync, it will > also > fix these: > > arch/powerpc/platforms/powernv/pci-ioda.c:1365:5: warning: symbol > 'pnv_phb_to_cxl' was not declared. Should it be static? > arch/powerpc/platforms/powernv/pci-ioda.c:1389:5: warning: symbol > 'pnv_cxl_alloc_hwirqs' was not declared. Should it be static? > arch/powerpc/platforms/powernv/pci-ioda.c:1404:6: warning: symbol > 'pnv_cxl_release_hwirqs' was not declared. Should it be static? > arch/powerpc/platforms/powernv/pci-ioda.c:1413:6: warning: symbol > 'pnv_cxl_release_hwirq_ranges' was not declared. Should it be static? > arch/powerpc/platforms/powernv/pci-ioda.c:1433:5: warning: symbol > 'pnv_cxl_alloc_hwirq_ranges' was not declared. Should it be static? > arch/powerpc/platforms/powernv/pci-ioda.c:1470:5: warning: symbol > 'pnv_cxl_get_irq_count' was not declared. Should it be static? > arch/powerpc/platforms/powernv/pci-ioda.c:1479:5: warning: symbol > 'pnv_cxl_ioda_msi_setup' was not declared. Should it be static?
Ok... will fix. Mikey _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
