It looks good for me. Liu Gang
> -----Original Message----- > From: Martijn de Gouw [mailto:martijn.de.g...@prodrive-technologies.com] > Sent: Tuesday, August 12, 2014 4:48 PM > To: Wood Scott-B07421 > Cc: linuxppc-dev@lists.ozlabs.org; alexandre.boun...@idt.com; > stef.van...@prodrive-technologies.com; barry.w...@idt.com; Liu Gang- > B34182 > Subject: Re: [PATCH] fsl-rio: add support for mapping inbound windows > > On 08/05/2014 11:37 PM, Scott Wood wrote: > > On Tue, 2014-08-05 at 15:52 +0200, Martijn de Gouw wrote: > >> Add support for mapping and unmapping of inbound rapidio windows. > >> > >> Signed-off-by: Martijn de Gouw > >> <martijn.de.g...@prodrive-technologies.com> > > > > Could you elaborate in the changelog on what this fixes or makes > > possible? E.g. did the driver previously not support inbound > > transactions at all, or did it assume the window was set up by a > > bootloader? > > Something like: > > fsl-rio: add support for mapping inbound windows > > Add support for mapping and unmapping of inbound rapidio windows. > This allows for drivers to open up a part of local memory on the > rapidio network. Also applications can use this and tranfer blocks > of data over the network. > > > > > Liu Gang, could you review this? > > I'll wait for the review before I post a new version. > > Gr, Martijn > > > -- > Martijn de Gouw > Engineer > Prodrive Technologies B.V. > Mobile: +31 63 17 76 161 > Phone: +31 40 26 76 200 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
