Hi, On Fri, Sep 12, 2014 at 10:01:12AM +0800, Shengjiu Wang wrote: > On Thu, Sep 11, 2014 at 03:57:37PM -0700, Nicolin Chen wrote: > > On Thu, Sep 11, 2014 at 01:38:29PM +0800, Shengjiu Wang wrote: > > > Move the ipg clock enable and disable operation to startup and shutdown, > > > that is only enable ipg clock when ssi is working. Keep clock is disabled > > > when ssi is in idle. > > > otherwise, _fsl_ssi_set_dai_fmt function need to be called in probe, > > > so add ipg clock control for it. > > > > It seems to be no objection so far against my last suggestion to > > use regmap's mmio_clk() for named ipg clk only. So you may still > > consider about that. > > > I think mmio_clk() can be put to another patch. and this patch only for > clk_enable() > and clk_disable() operation.
I would also prefer Nicolin's suggestion using regmap's mmio clk. I think it may be better to not add this particular patch at all and just go with the mmio_clk patch. It should be easy enough to just add the clock names to the devicetrees. That way we can avoid all those clock enable/disable function calls. > > > Anyway, I'd like to do thing in parallel. So I just simply tested > > it on my side and its works fine, it may still need to be tested > > by others though. > > > > Nicolina > > Hi Markus > > could you please review it, and share your comments? I think the clock enabling for AC97 is missing in your patch. Best regards, Markus -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
signature.asc
Description: Digital signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
