On 1 September 2014 10:48, Shilpa Bhat <shilpa.b...@linux.vnet.ibm.com> wrote: > Hi Viresh, > On Fri, 2014-08-29 at 05:33 +0530, Viresh Kumar wrote: >> On 28 August 2014 19:36, Shilpasri G Bhat >> <shilpa.b...@linux.vnet.ibm.com> wrote: >> > >> > Changes v1->v2: >> > Invoke .target() driver callback to set the cpus to nominal frequency >> > in reboot notifier, instead of calling cpufreq_suspend() as suggested >> > by Viresh Kumar. >> > Modified the commit message. >> >> This changelog will get commited, is this what you want?
You skipped replying to this and commited the same mistake again.. > > This patch ensures the cpus to kexec/reboot at nominal frequency. > Nominal frequency is the highest cpu frequency on PowerPC at > which the cores can run without getting throttled. > > If the host kernel had set the cpus to a low pstate and then it > kexecs/reboots to a cpufreq disabled kernel it would cause the target > kernel to perform poorly. It will also increase the boot up time of > the target kernel. So set the cpus to high pstate, in this case to > nominal frequency before rebooting to avoid such scenarios. > > The reboot notifier will set the cpus to nominal frequncy. > > Changes v1->v2: > Invoke .target() driver callback to set the cpus to nominal frequency > in reboot notifier, instead of calling cpufreq_suspend() as suggested > by Viresh Kumar. > Modified the commit message. This would get commited in git changelogs and probably you don't want this. So please place them after the three dash '-' symbols below.. > Signed-off-by: Shilpasri G Bhat <shilpa.b...@linux.vnet.ibm.com> > Suggested-by: Viresh Kumar <viresh.ku...@linaro.org> > Reviewed-by: Preeti U Murthy <pre...@linux.vnet.ibm.com> > --- HERE>>>>>>>>>>> > drivers/cpufreq/powernv-cpufreq.c | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) I have already Acked this, so you could have added that yourself on this resend. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
