On Thu, 2014-08-21 at 10:51 -0500, Robert Jennings wrote: > On 08/20/2014 11:41 PM, Michael Ellerman wrote: > > On Wed, 2014-08-13 at 14:48 +0530, Himangi Saraogi wrote: > >> Continue is not needed at the bottom of a loop. > > > > True. > > > > I wonder though, is the code trying to continue to the outer loop? > > I stared at it for a minute but it wasn't obvious. > > > > I wonder if Robert still remembers? > > I don't recall what the intent was here. Can't believe that it's been > almost 5 years since I wrote this. I wish I had left a few more > comments in the code for me to go on. > > Obviously the continue should be removed since it's not doing > anything. I don't believe that we'd want a continue statement in > there to get outer loop. That would change the current cmm_page_array > pointer (pa_curr) to the next in the list after it may have just been > reassigned to pa_last->next. > > It may be the case that an earlier version of the code had statements > in the inner loop after that continue that I wanted to skip, or I just > did something silly.
OK, thanks for looking at it. I came to a similar conclusion, but good to have your review as well. The CMM regression test suite will catch us if we get it wrong anyway. cheers _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
