On Wed, Aug 20, 2014 at 3:49 AM, Geert Uytterhoeven <ge...@linux-m68k.org> wrote:
> Is this a randconfig kernel? Yes, randconfig with ARCH=powerpc. > > config ARCH_SPARSEMEM_DEFAULT > def_bool y > depends on (SMP && PPC_PSERIES) || PPC_PS3 > > Why is this not enabled? !SMP? !PPC_PSERIES? !PPC_PS3? This was indeed enabled, but that does not do much. We will need CONFIG_SPARSEMEM which depends on CONFIG_SPARSEMEM_MANUAL which was not enabled. > > If PPC_CELL is enabled, this issue was introduced by > > commit 78bde53e351bc89cff85d1c2c7e6d7c2ffdf120d > Author: Benjamin Herrenschmidt <b...@kernel.crashing.org> > Date: Tue Feb 13 11:46:06 2007 +1100 > > [POWERPC] spufs: remove need for struct page for SPEs > > This patch removes the need for struct page for SPE local store > and registers from spufs. It also makes the locking much more > obvious and no longer relying on the truncate logic black magic > for protecting against races between unmap_mapping_range() and > new pages faulted in. It does so by switching to a nopfn() handler > and using the new vm_insert_pfn() to setup the PTEs itself while > holding a lock on the SPE. > > The nice thing is that this patch actually removes a lot more code > than it adds :-) > > Signed-off-by: Benjamin Herrenschmidt <b...@kernel.crashing.org> > Signed-off-by: Paul Mackerras <pau...@samba.org> > > > Another question: why does SPU_FS select MEMORY_HOTPLUG? Not really sure :( > > commit 4da30d15b6d5036b0d96422d6946ca758111fae3 > Author: Geoff Levand <geoffrey.lev...@am.sony.com> > Date: Fri Jun 23 20:57:49 2006 +0200 > > [POWERPC] spufs: fix memory hotplug dependency > > spufs_base.c calls __add_pages, which depends on CONFIG_MEMORY_HOTPLUG. > > Moved the selection of CONFIG_MEMORY_HOTPLUG from CONFIG_SPUFS_MMAP > to CONFIG_SPU_FS. > > Signed-off-by: Geoff Levand <geoffrey.lev...@am.sony.com> > Signed-off-by: Arnd Bergmann <arnd.bergm...@de.ibm.com> > Signed-off-by: Paul Mackerras <pau...@samba.org> > > However, the call to __add_pages() has been moved a few times afterwards, > to be finally removed in the aforementioned commit > 78bde53e351bc89cff85d1c2c7e6d7c2ffdf120d. > > Does it still build/work if you just drop the "select MEMORY_HOTPLUG"? I should have saved the config file :(. I think it will build since the problem was that hotplug-memory.o needs CONFIG_SPARSEMEM. -- Pranith _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
